So, I think these are the 4 best play-scale X-Wings Lego has made. In terms of their looks and functionality. I think the 2018 model is the best-looking overall. But it's got the rubber band S-foil mechanism which will wear out eventually and need to be replaced. (it's already starting to happen with mine) The technic, friction-based mechanism from the newer couple of X-Wings is a masterful work of Lego engineering, and I think will last for a much longer time.
Poe Dameron's X-Wing is also an awesome-looking set. I know it's a T-70 X-Wing and not a T-65, so maybe I can't call it a part of the same "squadron". But I love it all the same and it's part of the X-Wing family. It also has a rubber band-based mechanism but I think they did a better job of designing it for that one. I'm not seeing any wear on the bands yet even though I've had the set for years.
What version do you guys like the best?